Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix PR coverage when a package is added/removed #109442

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

RaduBerinde
Copy link
Member

The PR coverage script for running tests fails if a package does not exist (because it was added or removed in the PR). This change improves the script to ignore package paths for which a BUILD.bazel does not exist.

Epic: none
Release note: None

The PR coverage script for running tests fails if a package does not
exist (because it was added or removed in the PR). This change
improves the script to ignore package paths for which a `BUILD.bazel`
does not exist.

Epic: none
Release note: None
@RaduBerinde RaduBerinde requested a review from a team as a code owner August 24, 2023 17:44
@RaduBerinde
Copy link
Member Author

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@RaduBerinde
Copy link
Member Author

TFTR!

@RaduBerinde
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 24, 2023

Build succeeded:

@craig craig bot merged commit 7437f5e into cockroachdb:master Aug 24, 2023
8 checks passed
@RaduBerinde RaduBerinde deleted the fix-missing-pkg branch August 24, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants