concurrency: use generic lists in the lock table #109511
Conversation
Now that cda4fa2 has landed, we can make use of generic lists in a few places in the lock table. Epic: none Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @arulajmani)
pkg/kv/kvserver/concurrency/lock_table.go line 1476 at r1 (raw file):
// waiting for. // queuedLockingRequests is of requests queued at a key. They may be waiting
"is a list of locking requests"?
pkg/kv/kvserver/concurrency/lock_table.go line 1576 at r1 (raw file):
queuedLockingRequests list.List[*queuedGuard] // waitingReaders is the list of non-locking reads that are actively waiting.
nit: "is a list"?
Burns down a TODO. Epic: none Release note: None
arulajmani
force-pushed
the
sl-quality-fridays
branch
from
2b1a106
to
a4dcc18
Compare
There was a problem hiding this comment.
TFTR! Thanks for pushing on the generics patch -- this stuff looks way nicer now!
bors r=nvanbenschoten
Reviewable status:
pkg/kv/kvserver/concurrency/lock_table.go line 1476 at r1 (raw file):
Previously, nvanbenschoten (Nathan VanBenschoten) wrote…
"is a list of locking requests"?
🤦
|
Build succeeded: |
Now that cda4fa2 has landed, we can make use of generic lists in a few places in the lock table.
Epic: none
Release note: None