*: remove old-style build directives #111156
Conversation
RaduBerinde
requested review from
srosenberg,
smg260,
dhartunian,
michae2 and
bananabrick
and removed request for
a team
|
This change is |
pkg/col/coldata/BUILD.bazel
Outdated
| @@ -12,12 +12,14 @@ go_library( | |||
| "nulls.go", | |||
| "testutils.go", | |||
| "vec.go", | |||
| "vec_tmpl.go", | |||
There was a problem hiding this comment.
@yuzefovich any idea why this file wasn't her and/or why dev gen bazel suddenly decided to add it now?
There was a problem hiding this comment.
I reverted the changes to the coldata/colexec stuff for now.
| "//conditions:default": [], | ||
| }), | ||
| "@org_golang_x_sys//unix", | ||
| ], |
There was a problem hiding this comment.
@rickystewart any idea why gazelle made this change?
There was a problem hiding this comment.
Ah, it feels like the old-style tag was preventing it from understanding that we don't build that file on all these platforms.
There was a problem hiding this comment.
Ah, or it's the other way, it used to be able to exclude the dependency depending on the tag :/
There was a problem hiding this comment.
I'm guessing our gazelle version predates this change bazelbuild/bazel-gazelle#1243
The newer `go:build` directives have been supported since go 1.17, and the old ones have been deprecated in go 1.18. This commit removes all old-style directives. Epic: none Release note: None
RaduBerinde
force-pushed
the
build-directives
branch
from
f479f5d
to
3524294
Compare
|
I tried to update Gazelle, and (after working through a couple of issues) got stuck at this error: Will close this PR for now and reopen when gazelle supports the |
The newer
go:builddirectives have been supported since go 1.17, and the old ones have been deprecated in go 1.18. This commit removes all old-style directives.Epic: none
Release note: None