Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: clean up and reduce the TableName public interface. #15030

Closed
wants to merge 1 commit into from
Closed

sql: clean up and reduce the TableName public interface. #15030

wants to merge 1 commit into from

Conversation

knz
Copy link
Contributor

@knz knz commented Apr 18, 2017

Baby step towards #10083.

@knz knz requested a review from jordanlewis April 18, 2017 12:21
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jordanlewis
Copy link
Member

:lgtm: although as a suggestion for next time the commit message didn't really help me understand what I'm looking at. This change seems sound, but a little more justification and/or explanation of what the change is doing would help me review it next time.

Review status: 0 of 13 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

@knz
Copy link
Contributor Author

knz commented Apr 27, 2017

TFYR; I realized the context was missing and also thinking about it more I realized the change was not necessary.
Superseded by #15388.

@knz knz closed this Apr 27, 2017
@knz knz deleted the rename-views branch April 27, 2018 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanlewis jordanlewis Awaiting requested review from jordanlewis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knz @cockroach-teamcity @jordanlewis