sql/parser: fix <TYPE> '<value>' literal casts #22397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cockroachdb#22390. Our grammar had confused `const_typename` and `simple_typename`, which was preventing us from properly parsing <TYPE> <value> literal casts. This change fixes that. Release note (bug fix): <TYPE> <value> literal casts now work correctly for all fixed-length types.
|
This change is |
|
Review status: 0 of 3 files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22390.
Our grammar had confused
const_typenameandsimple_typename, whichwas preventing us from properly parsing literal casts.
This change fixes that.
Release note (bug fix): literal casts now work correctly
for all fixed-length types.