Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv/kvserver: mv testdata/lock_table/add_discovered out of pkg/storage #46631

Merged

Conversation

nvanbenschoten
Copy link
Member

This testdata file was added in #45601. That skewed with the mass package rename.

Release justification: testing only

@cockroach-teamcity
Copy link
Member

This change is Reviewable

This testdata file was added in cockroachdb#45601. That skewed with the package
rename.

Release justification: testing only
Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @sumeerbhola)

@nvanbenschoten
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 27, 2020

Build failed

@nvanbenschoten
Copy link
Member Author

Flaked on #44732.

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 27, 2020

Build succeeded

@craig craig bot merged commit d8cef26 into cockroachdb:master Mar 27, 2020
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/lockTableTest branch March 30, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants