sql: disallow cross-database foreign keys #54407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaduBerinde
requested review from
jordanlewis,
a team and
pbardea
and removed request for
a team
|
This change is |
RaduBerinde
force-pushed
the
no-cross-db-fk
branch
from
cae06f2
to
94e1754
Compare
ajwerner
approved these changes
Sep 15, 2020
There was a problem hiding this comment.
Reviewed 4 of 7 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis and @pbardea)
RaduBerinde
force-pushed
the
no-cross-db-fk
branch
from
94e1754
to
3e07ddb
Compare
RaduBerinde
force-pushed
the
no-cross-db-fk
branch
from
3e07ddb
to
2ea6868
Compare
This change disallows cross-database foreign key references and adds a cluster setting to allow them (false by default). Informs cockroachdb#54126. Release note (sql change): creating cross-database foreign key references is now disallowed (and can be re-enabled via a cluster setting).
RaduBerinde
force-pushed
the
no-cross-db-fk
branch
from
2ea6868
to
65d957e
Compare
|
bors r+ |
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change disallows cross-database foreign key references and adds
a cluster setting to allow them (false by default).
Informs #54126.
Release note (sql change): creating cross-database foreign key
references is now disallowed (and can be re-enabled via a cluster
setting).