sql: disallow moving tables with user-defined types into a different DB #55779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We disallow columns using user-defined types in a different database from the table at creation time. However, we have a loophole where it's possible to move the table to a different database using `RENAME` and thus create a cross-database reference. This breaks backup/restore and is generally unintended. This PR adds a check to disallow this. Release note (bug fix): Tables can no longer be moved to a different database using `RENAME` if they have columns using user-defined types (enums).
|
This change is |
ajwerner
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
TFTR, let's see what happens with the tests. bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We disallow columns using user-defined types in a different database
from the table at creation time. However, we have a loophole where it's
possible to move the table to a different database using
RENAMEandthus create a cross-database reference. This breaks backup/restore and
is generally unintended. This PR adds a check to disallow this.
Partially addresses #55709.
Related to #55772.
Release note (bug fix): Tables can no longer be moved to a different
database using
RENAMEif they have columns using user-defined types(enums).