bazel: provide way to run lint in bazel #65518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rickystewart
force-pushed
the
fulllint
branch
3 times, most recently
from
6a127dd
to
0c6ffba
Compare
rail
approved these changes
May 25, 2021
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rail)
DEPS.bzl, line 2345 at r1 (raw file):
build_file_proto_mode = "disable_global", importpath = "github.com/knz/go-libedit", patch_args = ["-p1"],
Interesting. Does it mean that you can't have multiple patches with different patch level? Sounds like a flaw in gazelle.
Yeah, it's weird. We haven't had to do too much with these patches so far, so it hasn't affected us. bors r=rail |
|
Build failed: |
|
No idea what went wrong, let's try that again. bors r=rail |
|
bors r- |
|
Canceled. |
rickystewart
force-pushed
the
fulllint
branch
2 times, most recently
from
085ebbe
to
984877a
Compare
With this patch, lints can be run with `bazel run build/bazelutil:lint`. The test binary takes the typical Go command-line arguments, so e.g. `bazel run build/bazelutil:lint -- -test.v`. We model this as a `sh_binary` that depends on the lint test binary as well as all the dependencies that it has (`roachvet`, `crlfmt`, and others). The shell script is a light wrapper that finds the actual location of all the dependencies and stages them all in the `PATH` appropriately. We also need to munge `LDFLAGS` because the linter calls into the compiler in a couple places, and `cgo` wants to link into some of the C libraries (`libedit`, `libproj`, etc.) There are a couple tests that are still broken, which are skipped for now. As a next step, we'll want to get this running in CI. Closes cockroachdb#61555 Release note: None
|
bors r=rail |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch, lints can be run with
bazel run build/bazelutil:lint.The test binary takes the typical Go command-line arguments, so e.g.
bazel run build/bazelutil:lint -- -test.v.We model this as a
sh_binarythat depends on the lint test binary aswell as all the dependencies that it has (
roachvet,crlfmt, andothers). The shell script is a light wrapper that finds the actual
location of all the dependencies and stages them all in the
PATHappropriately. We also need to munge
LDFLAGSbecause the linter callsinto the compiler in a couple places, and
cgowants to link into someof the C libraries (
libedit,libproj, etc.)There are a couple tests that are still broken, which are skipped for
now. As a next step, we'll want to get this running in CI.
Closes #61555.
Release note: None