Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui,admission: observability improvements for admission control #68595

Merged
merged 1 commit into from
Aug 19, 2021

Commits on Aug 18, 2021

  1. ui,admission: observability improvements for admission control

    - Trace statements for latency incurred in admission queues.
    - Certain admission control metrics are now included in the
      overload dashboard. Specifically,
      - Resource bottlenecks can be identified using the
        "KV Admission Slots" and "KV Admission IO Tokens Exhausted
        Duration Per Second" graphs.
      - The rate at which admission control is admitting requests
        is in the "Admission Work Rate" graphs and the corresponding
        delay rate (for all requests) is in
        "Admission Delay Rate". Dividing the latter by the former
        gives the mean admission delay.
      - The 75th percentile delay for those requests that actually
        waited for admission is in the
        "Admission Delay: 75th percentile" graph.
      When admission control is off most of these graphs will be
      empty or zero, and the total KV admission slots will be 1.
    
    Informs cockroachdb#65955
    
    Release note (ui change): admission control metrics are added to
    Overload dashboard.
    sumeerbhola committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    5e44a7f View commit details
    Browse the repository at this point in the history