Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: add roachstress-ci.sh #70435

Closed
wants to merge 1 commit into from
Closed

roachtest: add roachstress-ci.sh #70435

wants to merge 1 commit into from

Conversation

tbg
Copy link
Member

@tbg tbg commented Sep 20, 2021 •
edited by erikgrinaker
Loading

This is a handy way to trigger a CI job that stresses roachtests.
For example:

BRANCH=release-21.2 SHA=99a4816fc272228a63df20dae3cc41d235e705f3
TEST=yscb/F/nodes=3/cpu=32 COUNT=10
./pkg/cmd/roachtest/roachstress-ci.sh

Resolves #69289.

Release note: None

@tbg
roachtest: add roachstress-ci.sh
bc32e14 
This is a handy way to trigger a CI job that stresses roachtests.
For example:

> BRANCH=release-21.2 SHA=99a4816fc272228a63df20dae3cc41d235e705f3
> TEST=yscb/F/nodes=3/cpu=32 COUNT=10
> ./pkg/cmd/roachtest/roachstress-ci.sh

Release note: None
@tbg tbg requested a review from a team as a code owner September 20, 2021 16:01
@tbg tbg requested review from otan and removed request for a team September 20, 2021 16:01
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg tbg requested review from erikgrinaker and removed request for otan September 20, 2021 16:01
@tbg
Copy link
Member Author

tbg commented Sep 20, 2021 •
edited
Loading

Testing: (Edit: this looks like it worked, except I had a typo in "ycsb" so it didn't actually work)

https://teamcity.cockroachdb.com/viewLog.html?buildId=3469592&buildTypeId=Cockroach_Nightlies_RoachtestStress
https://teamcity.cockroachdb.com/viewLog.html?buildId=3469593&buildTypeId=Cockroach_Nightlies_RoachtestStress

@tbg tbg mentioned this pull request Sep 20, 2021
Closed
erikgrinaker
erikgrinaker approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@erikgrinaker erikgrinaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@erikgrinaker
Copy link
Contributor

PS: looks like you committed the pkg/cmd/roachtest/.roachstress-ci.sh.swp swap file as well.

@erikgrinaker
Copy link
Contributor

Also, shouldn't these scripts be under scripts/?

stevendanna
stevendanna reviewed Sep 21, 2021
View reviewed changes
pkg/cmd/roachtest/roachstress-ci.sh
exit 1
fi

if [ ! -v TEAMCITY_TOKEN ]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and below we test if some variables are set. For variables where we require a value, we may want to explicitly check that they are non-empty, since a variable can be set but empty.

@tbg tbg mentioned this pull request Nov 4, 2021
Closed
@tbg tbg marked this pull request as draft December 20, 2021 12:56
@tbg tbg mentioned this pull request May 18, 2022
Closed
@tbg
Copy link
Member Author

tbg commented May 18, 2022

I'll close it but I linked it into #69289 so it can be picked up again from there.

@tbg tbg closed this May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevendanna stevendanna stevendanna left review comments

@erikgrinaker erikgrinaker erikgrinaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

roachtest: add script/command to stress roachtest
4 participants
@tbg @cockroach-teamcity @erikgrinaker @stevendanna