kvserver: de-flake TestRangefeedCheckpointsRecoverFromLeaseExpiration #75587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
We didn't account for a possibly stale distsender cache earlier,
misrouting the LeaseInfo request to the last known leaseholder. By
providing a hint with the new leaseholder, we were also making an
assertion on cache freshness. We skip the hint and do just what the test
wants -- ensuring a lease renewal. Repro-ed within seconds before this
commit:
dev test pkg/kv/kvserver \
-f TestRangefeedCheckpointsRecoverFromLeaseExpiration --stress
Release note: None
irfansharif
force-pushed
the
220126.deflake-TestRangefeedCheckpointsRecoverFromLeaseExpiration
branch
from
352b0f7
to
071ecc5
Compare
ajwerner
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @arulajmani and @nvanbenschoten)
|
Thanks! bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed: |
|
Unrelated failures (though my fault too: #75609). bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
irfansharif
deleted the
220126.deflake-TestRangefeedCheckpointsRecoverFromLeaseExpiration
branch
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75098.
We didn't account for a possibly stale distsender cache earlier,
misrouting the LeaseInfo request to the last known leaseholder. By
providing a hint with the new leaseholder, we were also making an
assertion on cache freshness. We skip the hint and do just what the test
wants -- ensuring a lease renewal. Repro-ed within seconds before this
commit:
Release note: None