physicalplan: add support for multi-stage execution of regr_avgx, regr_avgy, regr_intercept, regr_r2, and regr_slope aggregate functions. #76007
Conversation
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
This change is |
|
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
mneverov
changed the title
mneverov
changed the title
There was a problem hiding this comment.
@yuzefovich can you help me out with the changes in zone?
When I run testlogic with rewrite flag it modifies the zone test file, and the ccl tests are failing with the changes. I can adjust zone test expectations to make tests pass but the next rewrite will override the file.
There are no changes on master branch when I run testlogic with rewrite.
Reviewable status:
complete! 0 of 0 LGTMs obtained
There was a problem hiding this comment.
Hm, when I rewrite with your commit reverted (on 7c4e234), I do see changes in zone file too. Clearly, your change is not to blame. My guess is that we have an issue with -rewrite flag when retry option is specified for the queries, so I'd just revert the changes in zone file in your PR.
Reviewable status:
…r_avgy, regr_intercept, regr_r2, and regr_slope aggregate functions. See cockroachdb#58347. Release note (performance improvement): regr_avgx, regr_avgy, regr_intercept, regr_r2, and regr_slope aggregate functions are now evaluated more efficiently in a distributed setting
There was a problem hiding this comment.
thanks, reverted the changes in zone file.
Reviewable status:
mneverov
changed the title
There was a problem hiding this comment.
Nice, thanks!
bors r=yuzefovich
Reviewed 8 of 9 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:
|
Build succeeded: |
physicalplan: add support for multi-stage execution of regr_avgx, regr_avgy,
regr_intercept, regr_r2, and regr_slope aggregate functions.
See #58347.
Release note (performance improvement): regr_avgx, regr_avgy, regr_intercept,
regr_r2, and regr_slope aggregate functions are now evaluated more efficiently
in a distributed setting