release-22.1: cloud/gcp: add custom retryer for gcs storage, retry on stream INTERN… #85482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
CI looks broken, but otherwise LGTM. |
This was referenced Aug 3, 2022
rhu713
force-pushed
the
backport22.1-85024
branch
from
ead9d65
to
796ec6f
Compare
|
nit: can we edit the title to be prefixed with release-22.1: nit: can we add a release justification since this is a backport |
adityamaru
approved these changes
Aug 9, 2022
…AL_ERROR Currently, errors like `stream error: stream ID <x>; INTERNAL_ERROR; received from peer` are not being retried. Create a custom retryer to retry these errors as suggested by: googleapis/google-cloud-go#3735 googleapis/google-cloud-go#784 Fixes: cockroachdb#85217, cockroachdb#85216, cockroachdb#85204, cockroachdb#84162 Release note: None Release justification: add retries for temporary errors that were causing roachtests to fail.
rhu713
changed the title
rhu713
force-pushed
the
backport22.1-85024
branch
from
796ec6f
to
666f646
Compare
|
@rhu713 sorry I forgot to mention during the review but this should have a release note so that users facing the error during restore can confirm it has been resolved in the next release. cc: @kathancox incase the related docs issue isn't auto opened |
|
Just added a release note to the PR, but it won't be part of the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…AL_ERROR
Currently, errors like
stream error: stream ID <x>; INTERNAL_ERROR; received from peerare not being retried. Create a custom retryer to retry these errors as
suggested by:
googleapis/google-cloud-go#3735
googleapis/google-cloud-go#784
Fixes: #85217, #85216, #85204, #84162
Release note: None
Release note (enterprise change): retry google cloud requests that error with
stream error: INTERNAL_ERROR.
Release justification: add retries for temporary errors that were causing
roachtests to fail.