storage: fix mvcc stats on gc of range tombstone over del #87103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
aliher1911
force-pushed
the
gc_range_del_over_del
branch
3 times, most recently
from
6d64de8
to
6b3d98f
Compare
aliher1911
force-pushed
the
gc_range_del_over_del
branch
from
6b3d98f
to
c440f31
Compare
erikgrinaker
approved these changes
Aug 31, 2022
pkg/storage/mvcc.go
Outdated
Comment on lines
4830
to
4832
| ms.Add(updateStatsOnGC(gcKey.Key, metaKeySize, metaValSize, meta, | ||
| realKeyChanged.WallTime)) | ||
| } | ||
| } |
There was a problem hiding this comment.
I think something got messed up with the formatting here.
Previously if range tombstone was placed over delete, GC would not correctly update GC bytes age incorrectly using range tombstone ts as age of underlying tombstone. Release justification: Bugfix Release note: None
aliher1911
force-pushed
the
gc_range_del_over_del
branch
from
c440f31
to
ca07f5d
Compare
|
bors r=erikgrinaker |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if range tombstone was placed over delete, GC would
not correctly update GC bytes age incorrectly using range tombstone ts
as age of underlying tombstone.
Release justification: Bugfix
Release note: None
Fixing: #87042