Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pass custom timeout to testrace in CI #87474

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

healthy-pod
Copy link
Contributor

In #86363, we added a timeout to tests at the test binary level. Tests running with --config=race however use a custom timeout, different from the original default values set by bazel based on the test size.

This patch propagates those custom values to testrace in CI.

Release justification: Non-production code changes
Release note: None

In cockroachdb#86363, we added a timeout to tests at the test binary level.
Tests running with `--config=race` however use a custom
timeout, different from the original default values set by bazel
based on the test size.

This patch propagates those custom values to testrace in CI.

Release justification: Non-production code changes
Release note: None
@healthy-pod healthy-pod requested a review from a team as a code owner September 7, 2022 02:05
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@healthy-pod
Copy link
Contributor Author

TFTR!

bors r=rickystewart

@craig
Copy link
Contributor

craig bot commented Sep 8, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Sep 8, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Sep 8, 2022

Build failed:

@healthy-pod
Copy link
Contributor Author

bors retry

@craig
Copy link
Contributor

craig bot commented Sep 8, 2022

Build succeeded:

@craig craig bot merged commit ce55e1b into cockroachdb:master Sep 8, 2022
@healthy-pod healthy-pod deleted the fix-race-timeout branch September 20, 2022 23:31
@healthy-pod
Copy link
Contributor Author

blathers backport release-22.2

@blathers-crl
Copy link

blathers-crl bot commented Oct 3, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 7ac059f to blathers/backport-release-22.2-87474: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch release-22.2 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants