-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jobs: change job_info.info_key to string #99878
Conversation
64e54ad
to
7ec8080
Compare
removed the upgrade migration from this; if we get it into 23.1 before the beta, arguably we don't need it since that'll be the first release from which we need to be upgradable, and in that case we don't need the migration. If we did need to be upgradable, this PR would need to be much more complex and wrap every info table query in a conditional to cast or not cast to BYTES. Since it isn't doing that, there's no point in having the migration. |
TFTRs! bors r+ (red CI is green on everything except maybe_stress which is apparently just known to be busted) |
blathers backport 23.1 |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 7ec8080 to blathers/backport-release-23.1-99878: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Build failed (retrying...): |
This likely needs a rebase. bors r-
|
Canceled. |
thanks @yuzefovich!
bors r+ |
don't think bors noticed the comment since it didn't queue it. bors r+ |
bors r- please rebase. there's a merge conflict now. |
Canceled. |
Release note: none. Epic: none. Hopefully we get this one in now before it is released and harder to change later. I think if we go with bytes, we'll spend the next several years typing convert_to over and over, or forgetting to and then typing it, when debugging.
bors r+ |
Build succeeded: |
Release note: none.
Epic: none.
Hopefully we get this one in now before it is released and harder to change later. I think if we go with bytes, we'll spend the next several years typing convert_to over and over, or forgetting to and then typing it, when debugging.