Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] GitHub action doesn't fail even though cog check does #1

Closed
mbehr1 opened this issue Jan 9, 2022 · 2 comments
Closed

[BUG] GitHub action doesn't fail even though cog check does #1

mbehr1 opened this issue Jan 9, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@mbehr1
Copy link
Contributor

mbehr1 commented Jan 9, 2022

Describe the bug
Even though the commit message pushed/tested lets cog check fail the GitHub action succeeds.

To Reproduce
See here: https://github.com/mbehr1/adlt/runs/4753498724?check_suite_focus=true

Expected behavior
Action should fail if cog check fails.

Additional context
Seems as if the "shell=bash" used is set to shell: /usr/bin/sh -e {0} so will always return 0?

@mbehr1 mbehr1 added the bug Something isn't working label Jan 9, 2022
@oknozor
Copy link
Collaborator

oknozor commented Jan 9, 2022

Hey @mbehr1 this is fixed already in the latest github action version: cocogitto/[email protected].
Also you need to update your cog.toml file to match the latest version config (see: the config reference. You can also take a look at cocogitto's config.

I am closing this, don't hesitate to reopen if this does not work for you.

@oknozor oknozor closed this as completed Jan 9, 2022
@mbehr1
Copy link
Contributor Author

mbehr1 commented Jan 9, 2022

@oknozor thx! Yep, that's working now :-)
Btw: I changed to "uses: cocogitto/cocogitto-action@v2" and not to "uses: oknozor/cocogitto-...". Is that correct?
(Now I still struggle with the --from-latest-tag not working in CI. But will investigate a little further first :-)

mbehr1 added a commit to mbehr1/cocogitto-action that referenced this issue Jan 9, 2022
oknozor pushed a commit that referenced this issue Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants