Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webview #7873

Closed
wants to merge 3 commits into from
Closed

Add webview #7873

wants to merge 3 commits into from

Conversation

gin0606
Copy link
Contributor

@gin0606 gin0606 commented Aug 25, 2014

Hi @AndyQue
I try to add My WebView to cocos2d-x after lookng this issue. https://github.com/gin0606/cocos2dx-WebView/issues/2

But I have compile error from libui iOS.
I try to fix that. But I'm not sure if this is correct.
Would you please check this?

@zilongshanren
Copy link
Member

Thanks a lot @gin0606
Sure, I will take over this PR and fix the compile errors.
BTW, in order to merge your code into cocos2d-x repository, I have to change the license and namespace part. Since the WebView only works on Android and IOS platform, so we might need to put it under cocos2d::ui::experimental namespace.

@zilongshanren
Copy link
Member

@gin0606
The new PR is opened here: #7882 , please check it out.

@gin0606
Copy link
Contributor Author

gin0606 commented Aug 27, 2014

@AndyQue I will check it! Thank you!

@gin0606 gin0606 closed this Aug 27, 2014
@gin0606 gin0606 deleted the add_webview branch February 5, 2015 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants