Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #4000

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.10 → v0.5.0](astral-sh/ruff-pre-commit@v0.4.10...v0.5.0)
- [github.com/pre-commit/mirrors-clang-format: v18.1.7 → v18.1.8](pre-commit/mirrors-clang-format@v18.1.7...v18.1.8)
- [github.com/henryiii/validate-pyproject-schema-store: 2024.06.24 → 2024.07.01](henryiii/validate-pyproject-schema-store@2024.06.24...2024.07.01)
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.05%. Comparing base (ca6a97f) to head (83fb5f3).
Report is 149 commits behind head on master.

Files with missing lines Patch % Lines
src/cocotb/_xunit_reporter.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4000   +/-   ##
=======================================
  Coverage   73.05%   73.05%           
=======================================
  Files          50       50           
  Lines        8012     8012           
  Branches     2201     2201           
=======================================
  Hits         5853     5853           
  Misses       1643     1643           
  Partials      516      516           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ktbarrett
Copy link
Member

The error on redefining of _ is not good. That flies in the face of idiomatic code. Maybe there is additional config necessary?

@ktbarrett ktbarrett self-requested a review July 2, 2024 02:38
Copy link
Member

@ktbarrett ktbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix ruff config or complain upstream.

@ktbarrett
Copy link
Member

Opened astral-sh/ruff#12157 for the whole _ PLR1704 issue. Just reintroduced the parameter name as a quick fix.

@ktbarrett ktbarrett requested review from ktbarrett and a team July 3, 2024 13:34
@ktbarrett ktbarrett self-requested a review July 4, 2024 14:22
@ktbarrett ktbarrett force-pushed the pre-commit-ci-update-config branch from dfddabb to 83fb5f3 Compare July 4, 2024 14:25
@ktbarrett ktbarrett merged commit c386f6a into master Jul 4, 2024
29 checks passed
@ktbarrett ktbarrett deleted the pre-commit-ci-update-config branch July 4, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants