Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore cleanup #244

Merged
merged 1 commit into from
Dec 23, 2019
Merged

.gitignore cleanup #244

merged 1 commit into from
Dec 23, 2019

Conversation

kubawerlos
Copy link
Contributor

Directories/files IDE specific should be handled with global .gitignore.

@florianeckerstorfer
Copy link
Member

I agree that IDE-specific files should be ignored in your global .gitignore, however, since I am maintaining oss projects for a while now, I also know that not all contributors do this. Just having all these files in the projects .gitignore saves me a bit of work (and the mental burden of remembering to check).

I am open to be convinced otherwise if you can give me a good reason (better than the reason why keeping them in there) why they should not be in the projects .gitignore

@kubawerlos
Copy link
Contributor Author

If you change to global gitignore once with your IDE rules you won't have to bother anymore about it anymore - it's win-win situation. And if this will make a trouble to anyone maybe we can convince that contributor to start using global gitignore.

I fully agree wit this article: https://dev.to/oleksiyrudenko/please-do-not-pollute-projects-gitignore-3h8e

@OskarStark
Copy link
Contributor

I am 👍🏻

phpunit.xml
humbuglog.txt
/composer.lock
/phpunit.xml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe .dist and rename the file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the question - we have .dist file and ignore phpunit.xml, what would you like to change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name it phpunit.xml.dist as it’s a best practice AFAIK and the ignore that file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't get it, what do you want to name phpunit.xml.dist?

AFAIK best practice is to have phpunit.xml.dist and ignore phpunit.xml - exactly what we have right now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are totallly right I mixed things up 😂 Christmas is coming... need to relax more 😉

@florianeckerstorfer florianeckerstorfer merged commit 62c1a7a into cocur:master Dec 23, 2019
@kubawerlos kubawerlos deleted the gitignore-cleanup branch December 23, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants