Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable some package auto updates #2645

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Disable some package auto updates #2645

merged 3 commits into from
Jun 7, 2023

Conversation

huayang-codaio
Copy link
Contributor

@huayang-codaio huayang-codaio requested a review from a team as a code owner June 6, 2023 00:12
dweitzman-codaio
dweitzman-codaio reviewed Jun 6, 2023
View reviewed changes
renovate.json5 Outdated
// see https://github.com/coda/packs-sdk/pull/2642
{
packageNames: ['open'],
allowedVersions: '8.4.2',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make this <9.0.0 to allow for minor and patch releases?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, FYI I forced the off-schedule the creation of the PRs for these so I'd have a place to comment about them

I think closing the renovate PR for open will also discourage it from trying to mail PRs for the same major version in the future: https://docs.renovatebot.com/key-concepts/pull-requests/#normal-prs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah that's good to know. I was wondering how to control the renovate PRs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you haven't seen it, there's also an issue at #2464 where you toggle a checkbox to force off-schedule PR creation or rebase a bunch of PRs at once

@huayang-codaio huayang-codaio merged commit 742628f into main Jun 7, 2023
@huayang-codaio huayang-codaio deleted the hg-disable-some-package-bumps branch June 7, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweitzman-codaio dweitzman-codaio dweitzman-codaio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huayang-codaio @dweitzman-codaio