Create a .nvmrc file so "nvm use" will pick an appropriate node version #2835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweitzman-codaio
requested review from
jonathan-codaio,
huayang-codaio,
alan-codaio and
ekoleda-codaio
jonathan-codaio
approved these changes
Nov 30, 2023
|
I added a note in |
| if command -v nvm &> /dev/null | ||
| then | ||
| # Gets version from .nvmrc | ||
| nvm use |
There was a problem hiding this comment.
This will instruct people to run nvm install v18 if they haven't already, so I figured it's probably fine not to mention that directly in the CONTRIBUTING instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personally this is what I do. Might be useful to other people as well?...