Add mergeKey to IdentityDefinition #3037
Conversation
oleg-codaio
force-pushed
the
osv-add-mergekey-to-identitydefinition
branch
from
f5c13cb
to
6e7b698
Compare
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@codahq/packs-sdk", | |||
| "version": "1.7.10-prerelease.1", | |||
There was a problem hiding this comment.
don't you mean 1.7.11?
There was a problem hiding this comment.
(though we should have already been on 11-prerelease technically)
There was a problem hiding this comment.
Ah yup, I had to temporarily change the version to 1.7.10 to get make release-manual to work.
oleg-codaio
force-pushed
the
osv-add-mergekey-to-identitydefinition
branch
2 times, most recently
from
59b5de2
to
09d6fd9
Compare
schema.ts
Outdated
| @@ -992,6 +992,14 @@ export interface IdentityDefinition { | |||
| dynamicUrl?: string; | |||
| /** The ID of another pack, if you are trying to reference a value from different pack. */ | |||
| packId?: number; | |||
| /** | |||
| * By default, result sets returned by dynamic sync tables will not be merged together for the purposes of presenting | |||
There was a problem hiding this comment.
perhaps "merged together across different dynamicUrl values"?
There was a problem hiding this comment.
Yup, will update before merging. (Since I released already though won't cut another release for the correction.).
| @@ -2,8 +2,6 @@ | |||
|
|
|||
| This changelog keeps track of all changes to the Packs SDK. We follow conventions from [keepachangelog](https://keepachangelog.com/en/1.0.0/). | |||
|
|
|||
| ## [Unreleased] | |||
There was a problem hiding this comment.
I was wrestling with make release-manual - thought maybe I could bypass release notes for this release since there are no external-facing updates.
There was a problem hiding this comment.
in the future, i think it'd be better to do releases as separate PRs from the actual changes
oleg-codaio
force-pushed
the
osv-add-mergekey-to-identitydefinition
branch
from
09d6fd9
to
6e2587f
Compare
Adding property for internal use for now.
PTAL @coda/packs