Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [TCE-1039] Add parameter 'registryAddress' in order to support alternative registry addresses for duplication and complexity tools #512

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

hjrocha
Copy link
Contributor

@hjrocha hjrocha commented Jul 11, 2024

No description provided.

Copy link

Example

Add parameter 'registryAddress' in order to support alternative registry addresses for duplication and complexity tools

This pull request introduces a new parameter registryAddress to the CLI script and the tool selectors.
This change allows users to specify an alternative registry address for the duplication and complexity tools.

  • The CLI script now accepts a new parameter registryAddress
  • The tool selectors have been updated to accept a new parameter registryAddress

REFERENCES


This comment was generated by an experimental AI tool (winner of the 2024 Codacy Hackathon 'People's Choice' and 'Most Valuable' awards).

Copy link

codacy-production bot commented Jul 11, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+12.29% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0091e95) 1277 1046 81.91%
Head commit (56db9c0) 224 (-1053) 211 (-835) 94.20% (+12.29%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#512) 8 8 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@hjrocha hjrocha enabled auto-merge July 11, 2024 13:13
@hjrocha hjrocha requested a review from machadoit July 11, 2024 13:13
Copy link
Member

@machadoit machadoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a bit strange that on some places we add it, and on others we pass it around like the DuplicationTool on the trait or class. But if you tried locally and seems fine, works for me

@hjrocha hjrocha merged commit b499a22 into master Jul 11, 2024
8 checks passed
@hjrocha hjrocha deleted the add-custom-registry branch July 11, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants