Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump pylint version 1.7.5 > 1.8.2 #29

Merged
merged 3 commits into from
Feb 6, 2018

Conversation

simobasso
Copy link
Contributor

in order to fix unused variable __class__ and because we have
astroid at the version 1.6.x we must upgrade pylint

@simobasso simobasso changed the title build: bump pylint version 1.7.5 > 1.8.1 WIP build: bump pylint version 1.7.5 > 1.8.1 Jan 23, 2018
@simobasso simobasso force-pushed the pylint_181 branch 3 times, most recently from 89e9e45 to 8fb98f0 Compare January 23, 2018 14:43
@simobasso
Copy link
Contributor Author

simobasso added a commit to simobasso/pylint-django that referenced this pull request Jan 23, 2018
@simobasso simobasso force-pushed the pylint_181 branch 2 times, most recently from ab3b8eb to 5defe68 Compare January 23, 2018 21:31
simobasso added a commit to simobasso/pylint-django that referenced this pull request Jan 23, 2018
@simobasso
Copy link
Contributor Author

we have to wait pylint-dev/pylint-django#121 but tests are all green! 🎉

when the PR will be merged in upstream and a new pylint-django will be released I'll update this pr

atodorov pushed a commit to pylint-dev/pylint-django that referenced this pull request Jan 24, 2018
in order to fix `unused variable __class__` and because we have
astroid at the version `1.6.x` we must upgrade pylint
@simobasso simobasso changed the title WIP build: bump pylint version 1.7.5 > 1.8.1 WIP build: bump pylint version 1.7.5 > 1.8.2 Jan 25, 2018
@simobasso simobasso changed the title WIP build: bump pylint version 1.7.5 > 1.8.2 build: bump pylint version 1.7.5 > 1.8.2 Jan 25, 2018
@simobasso
Copy link
Contributor Author

@rtfpessoa updated! 🌮

@simobasso
Copy link
Contributor Author

ehi @rtfpessoa do you need a rebase?

@rtfpessoa
Copy link
Contributor

@simobasso I was able to do it in the UI. Should be merged soon if all goes ok.

@rtfpessoa rtfpessoa merged commit 93824ab into codacy:master Feb 6, 2018
@simobasso simobasso deleted the pylint_181 branch February 6, 2018 11:13
@simobasso
Copy link
Contributor Author

🎉

atodorov pushed a commit to pylint-dev/pylint-django that referenced this pull request Nov 5, 2018
atodorov pushed a commit to pylint-dev/pylint-django that referenced this pull request Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants