Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release PR#1 - Display release version in Codabench footer #1583

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Sep 14, 2024

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Now we can display release version in the header just below the main logo
Screenshot 2024-09-14 at 11 20 35 PM

Issues this PR resolves

A checklist for hand testing

  • collectstatic and check that the current version is displayed correctly

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ObadaS
Copy link
Collaborator

ObadaS commented Sep 16, 2024

This looks pretty good in my opinion.

How much more work would it be to make this clickable, bringing to the Github release ?
Also, can it automatically go fetch the version number in the version.json file you created from #1584 ?
From what I see, we have to manually change it after each update if we keep everything like this, right ?

@ihsaan-ullah
Copy link
Collaborator Author

In the next PR we will fetch it from the version.json and make it clickable

@Didayolo
Copy link
Member

Hi @ihsaan-ullah, thanks for the PR. I think this is too much visible. We should put it at the bottom of the page in my opinion. Also it could be added to base.html to appear in every pages on the bottom banner.

Capture d’écran 2024-09-16 à 20 53 20

@ihsaan-ullah
Copy link
Collaborator Author

ihsaan-ullah commented Sep 17, 2024

Version moved to footer and is now clickable

Screenshot 2024-09-17 at 11 40 43 AM

@Didayolo Didayolo self-assigned this Sep 18, 2024
@Didayolo
Copy link
Member

@ihsaan-ullah Very good. Are we still waiting the addition of a json file before merging this?

@ihsaan-ullah
Copy link
Collaborator Author

@ihsaan-ullah Very good. Are we still waiting the addition of a json file before merging this?

You can merge this one. I will handle the json file in another PR

@ihsaan-ullah ihsaan-ullah changed the title Display release version in Codabench header Display release version in Codabench footer Sep 19, 2024
@ihsaan-ullah ihsaan-ullah changed the title Display release version in Codabench footer Release PR#1 - Display release version in Codabench footer Sep 20, 2024
@ihsaan-ullah ihsaan-ullah mentioned this pull request Sep 21, 2024
@Didayolo Didayolo merged commit 747acb2 into develop Oct 1, 2024
1 check was pending
@Didayolo Didayolo deleted the codabench_version branch October 1, 2024 20:29
Didayolo added a commit that referenced this pull request Oct 11, 2024
* autorun collectstatic when django container starts, added caddy_data and caddy_config to gitignore

* programs and datasets bug fixed

* if condition format fixed

* Downloading submissions witha stream v1

* updated toml file with python version and bpython version, deleted lock file, update dockerfile to not copy lock file and to generate lock file in the docker build

* Change base image for Dockerfile.flower (#1520)

* Change base image for Dockerfile.flower

* Remove platform argument

* Resources bundles dumps (#1505)

* Add a Bundles tab in Resources view

* add dump single and multiple deletion mechanism

* add competition title in bundle name + add competition link in bundle resource tab

* Update datasets.py (flake8)

---------

Co-authored-by: OhMaley <[email protected]>
Co-authored-by: Adrien Pavão <[email protected]>

* Improve formatting

* leaderboard api 500 error resolved (#1527)

* leaderboard api 500 error resolved

* flake issues resolved

* Changed submission name to add ID when downloading many submissions (#1565)

* changed submission name to add ID

* Flake8 white space fix

---------

Co-authored-by: Nicolas HOMBERG <[email protected]>

* Server Status:  submissions limit removed (#1562)

* server status submissions limit removed, pagination added, monitor queues separated

* renamed server status title to recent submissions

* Email template fixes (#1567)

* email logo fixed, some changes in email text

* participant side email templates updated

* task dataset/program removal fixed

* Updated docker-compose to docker compose

* whiltelist emails leaking fixed (#1560)

* competition whitelist feature added

* updated whitelist

* Update whitelist note

* whiltelist emails leaking fixed

* Remove conflict

---------

Co-authored-by: Adrien Pavão <[email protected]>

* Updates to server_status and monitor_queues (#1568)

* server_status and monitor_queues pages secured

* Update monitor_queues.html

* [Feature] Delete orphan files (#1575)

* Add button for orphan files deletion + API routes and views

* Fix flake8 formatting

---------

Co-authored-by: OhMaley <[email protected]>

* Fix string concat in case of no email in analytics api

* Poetry error tentative fix (#1588)

* Poetry error tentative fix

* RabbitMQ static image in Dockerfile.rabbitmq to fix a recent bug

* Reverted RabbitMQ image change

* Fix Rabbit version

---------

Co-authored-by: Obada Haddad <[email protected]>
Co-authored-by: didayolo <[email protected]>

* `Release PR#1` - Display release version in Codabench footer (#1583)

* release version added to header

* version moved to footer

* Minor UI change

---------

Co-authored-by: Adrien Pavão <[email protected]>

* `Release PR#2` Release version will load dynamically from version.json (#1592)

* release version added to header

* version moved to footer

* version on the website is now dynamic and will be loaded from the version.json file

---------

Co-authored-by: Adrien Pavão <[email protected]>

* `Release PR#3` created workflow for new releases (#1584)

* created workflow for new releases

* version json file added

* typo fix

* Update release-version-update.yml

* Included realease url to navigate user to the url on click on the website

* release json updated

---------

Co-authored-by: Obada Haddad <[email protected]>
Co-authored-by: Adrien Pavão <[email protected]>

* Updates Sept 15-22 2024 (#1593)

* jinja and pillow

* jinja and pillow

* Adding Versino_Bump_Instruction_README

* Version_Bumps file

* Version_Bumps file and req_treeFile updates

* gunicorn from 20.0.4 to 22.0.0

* Bump requests from 2.20.0 to 2.32.2

* Bump django from 2.2.17 to 2.2.18

* Bump django from 2.2.18 to 2.2.19 and to 3.2.25 eventually

* Bump django from 2.2.19 to 2.2.20

* Bump django from 2.2.20 to 2.2.25

* Bump django from 2.2.25 to 2.2.28

* Bump django from 2.2.25 to 2.2.28

* Version_Bumps.md text

* Update Dockerfile (upgrade Python)

* checking in some outstanding changes

* Remove Version Bumps

* removing version bumbs

---------

Co-authored-by: Adrien Pavão <[email protected]>

* organizers can now delete forum posts (#1613)

Co-authored-by: Adrien Pavão <[email protected]>

* bundles renamed to competition bundles, swapped postions of bundles and tasks (#1591)

Co-authored-by: Adrien Pavão <[email protected]>

---------

Co-authored-by: Ihsan Ullah <[email protected]>
Co-authored-by: Nicolas HOMBERG <[email protected]>
Co-authored-by: OhMaley <[email protected]>
Co-authored-by: Obada Haddad <[email protected]>
Co-authored-by: Obada Haddad-Soussac <[email protected]>
Co-authored-by: Benjamin Bearce <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants