Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle store details page #3860

Merged
merged 29 commits into from
Dec 14, 2021
Merged

Bundle store details page #3860

merged 29 commits into from
Dec 14, 2021

Conversation

jzwang43
Copy link
Contributor

@jzwang43 jzwang43 commented Oct 26, 2021

Reasons for making this change

Bundle store details page (https://worksheets.codalab.org/stores/[uuid]) - this should show: type of bundle store, location, owner)

This requires merging of #3828 as that PR fixes the API end points.

Related issues

#3859

Screenshots

image

Checklist

  • I've added a screenshot of the changes, if this is a frontend change
  • I've added and/or updated tests, if this is a backend change
  • I've run the pre-commit.sh script
  • I've updated docs, if needed

@jzwang43 jzwang43 changed the title added store view Bundle store details page Oct 26, 2021
Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add name field

@jzwang43 jzwang43 self-assigned this Dec 13, 2021
@jzwang43 jzwang43 marked this pull request as ready for review December 13, 2021 07:36
Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jzwang43 can you update the branch with the latest master (git pull origin master) and fix CI? It looks good otherwise.

@mergify mergify bot merged commit 8f7d1e6 into master Dec 14, 2021
@mergify mergify bot deleted the bundle-details branch December 14, 2021 20:37
@jzwang43 jzwang43 mentioned this pull request Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants