Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support bundle checkpoint / preemptible workers #3882
Support bundle checkpoint / preemptible workers #3882
Changes from 16 commits
29f0a05
f784441
be45063
6425c3c
17615b7
d4c787c
d1454e9
48f4ec5
d28d669
a40a19a
d346f3e
9a7a16b
f674228
4ea0f52
ae1004c
c55877f
dbbb756
1180e6f
3c2c3ec
47eef0a
f226631
20db8a3
79aab01
4124e34
877269f
1ca7900
47f253c
59828ea
c3d1a21
030256f
311e34d
5a87afc
f5223a0
7abe85c
58932d1
a39bb2c
d6a1398
4c184d3
8596d05
a0dadc3
f0d1530
2dda725
0753818
314638e
dcf960b
743f507
0c6008c
8f9fd41
dea755e
184e405
289b1a2
78acc06
47aa494
5eac2d3
115b8b5
ca03ad1
03da441
4ad23e6
4061733
853d4bc
f978cb8
3e9c0c8
663d35b
0778d58
6a0a99d
962017f
71fb046
9dde912
6d45d83
6f6c44a
f397936
b77ec32
6423cc3
8ff8a4f
5c315a4
398bc81
3f5def8
6b03702
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't we access the preemptible field directly and have to use
getattr
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm worried that if we do
bundle.metadata["preemptible"]
, this will break bundles that started running in the previous deploy (but continue running during the deploy) that don't yet have this metadata key yet.