Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix worksheets display limit #3885

Merged
merged 4 commits into from
Nov 22, 2021
Merged

Fix worksheets display limit #3885

merged 4 commits into from
Nov 22, 2021

Conversation

jzwang43
Copy link
Contributor

@jzwang43 jzwang43 commented Nov 16, 2021 •
edited
Loading

Reasons for making this change

The profile page is only displaying up to 10 worksheets instead of 100 for "my worksheets".

By default the limit is 10, we just need to specify limit to be 100.

Related issues

fixes #3838

Screenshots

image

Checklist

  • I've added a screenshot of the changes, if this is a frontend change
  • I've added and/or updated tests, if this is a backend change
  • I've run the pre-commit.sh script
  • I've updated docs, if needed

@jzwang43 jzwang43 self-assigned this Nov 16, 2021
@jzwang43 jzwang43 changed the title fix worksheet limit Fix worksheets display limit Nov 16, 2021
epicfaace
epicfaace reviewed Nov 16, 2021
View reviewed changes
Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @pranavjain can you review and approve this?

pranavjain
pranavjain approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@pranavjain pranavjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We might want to change the limit to 100 directly in the backend to avoid setting this from the frontend.

@mergify mergify bot merged commit f5acc75 into master Nov 22, 2021
@mergify mergify bot deleted the fix/3838 branch November 22, 2021 23:41
@epicfaace epicfaace mentioned this pull request Dec 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epicfaace epicfaace epicfaace left review comments

@pranavjain pranavjain pranavjain approved these changes

Assignees

@jzwang43 jzwang43

Labels
frontend ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show more than 10 worksheets on user dashboard
3 participants
@jzwang43 @epicfaace @pranavjain