Fix store info display

[jzwang43]

Reasons for making this change

Legacy bundles will not have bundle stores so we won't show the store info if API returns empty.

BundleLocationListSchema(many=True).dump doesn't seem to be working so I'm using json.dumps for now.

Related issues

fixes #3910

Screenshots

For an old file upload:

New bundle:

Checklist

• I've added a screenshot of the changes, if this is a frontend change
• I've added and/or updated tests, if this is a backend change
• I've run the pre-commit.sh script
• I've updated docs, if needed

[epicfaace]

Looks good except for the BundleLocationListSchema(many=True).dump(bundle_locations).data part. Why didn't that work? did you get a specific error? Ideally, we would use that instead of using json.dump.

[jzwang43]

The schema is defined incorrectly I believe. The error is Unexpected Internal Error (Must have an id field). The administrators have been notified.

[epicfaace]

Are you sure that's the error you get? BundleLocationListSchema doesn't have an id field defined (https://github.com/codalab/codalab-worksheets/blob/fix-store-info/codalab/rest/schemas.py#L247-L255) (only BundleStoreSchema does)

[jzwang43]

Are you sure that's the error you get? BundleLocationListSchema doesn't have an id field defined (https://github.com/codalab/codalab-worksheets/blob/fix-store-info/codalab/rest/schemas.py#L247-L255) (only BundleStoreSchema does)

Yes I can confirm that's the error. If you look at the definition of the Schema class the BundleLocationListSchema extends, it requires an id field to be defined.

[epicfaace]

Are you sure that's the error you get? BundleLocationListSchema doesn't have an id field defined (https://github.com/codalab/codalab-worksheets/blob/fix-store-info/codalab/rest/schemas.py#L247-L255) (only BundleStoreSchema does)

Yes I can confirm that's the error. If you look at the definition of the Schema class the BundleLocationListSchema extends, it requires an id field to be defined.

Can you try reverting the BundleLocationListSchema(many=True).dump(bundle_locations).data -> json.dump change? I think the json change you did is causing the CI tests to fail. We should maybe get on a call to talk through this further to see what exactly the issue.

[jzwang43]

Are you sure that's the error you get? BundleLocationListSchema doesn't have an id field defined (https://github.com/codalab/codalab-worksheets/blob/fix-store-info/codalab/rest/schemas.py#L247-L255) (only BundleStoreSchema does)

Yes I can confirm that's the error. If you look at the definition of the Schema class the BundleLocationListSchema extends, it requires an id field to be defined.

Can you try reverting the BundleLocationListSchema(many=True).dump(bundle_locations).data -> json.dump change? I think the json change you did is causing the CI tests to fail. We should maybe get on a call to talk through this further to see what exactly the issue.

If I revert the json.dumps change then the endpoint wouldn't work and this page will be broken.
The previous API I used was an old one and doesn't support multiple bundle locations.

[epicfaace]

let's revert this file (which I changed in an attempt to fix the json issue)