-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support specifying --store with "cl run" #3916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comments.
docs/CLI-Reference.md
Outdated
-n, --name Short variable name (not necessarily unique); must conform to ^[a-zA-Z_][a-zA-Z0-9_\.\-]*$. | ||
-d, --description Full description of the bundle. | ||
--tags Space-separated list of tags used for search (e.g., machine-learning). | ||
--license The license under which this program/dataset is released. | ||
--source-url URL corresponding to the original source of this bundle. | ||
--link-url Link URL of bundle. | ||
--link-format Link format of bundle. Can be equal to"raw" or "zip" (only "raw" is supported as of now). | ||
--store The name of the bundle store where the bundle should be uploaded to.If unspecified, an optimal available bundle store will be chosen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a space after "to."
docs/CLI-Reference.md
Outdated
@@ -71,6 +70,7 @@ Usage: `cl <command> <arguments>` | |||
--request-priority Job priority (higher is more important). Negative priority bundles are queued behind bundles with no specified priority. | |||
--request-network Whether to allow network access. | |||
--exclude-patterns Exclude these file patterns from being saved into the bundle contents. | |||
--store The name of the bundle store where bundle results should be initially uploaded. If unspecified, an optimalavailable bundle store will be chosen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space after "optimal"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for lines 214 and 244.
Reasons for making this change