Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building docker files from scratch #3954

Merged
merged 7 commits into from
Jan 20, 2022
Merged

Fix building docker files from scratch #3954

merged 7 commits into from
Jan 20, 2022

Conversation

epicfaace
Copy link
Member

@epicfaace epicfaace commented Jan 18, 2022 •
edited by jzwang43
Loading

The previous ppa doesn't have python3.6 anymore, updated to use a new repository.

@epicfaace epicfaace mentioned this pull request Jan 18, 2022
Closed
@jzwang43
Copy link
Contributor

@epicfaace I tested checking out the branch and building the images. They seem to be working? Anything else I need to do other than start -bd to reproduce?

@epicfaace
Copy link
Member Author

@jzwang43 it's working because it's currently using the cache as of my latest commit. Try undoing my most recent commit (52f26a4) -- this will cause the cache to bust and then you'll see the error.

@jzwang43 jzwang43 marked this pull request as ready for review January 19, 2022 23:44
@jzwang43 jzwang43 changed the title test building docker files from scratch Fix building docker files from scratch Jan 19, 2022
@jzwang43
Copy link
Contributor

@epicfaace I updated the apt repository and the build should be working now:)

epicfaace
epicfaace commented Jan 20, 2022
View reviewed changes
Copy link
Member Author

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I think we might need to update the other dockerfiles too.

@jzwang43 jzwang43 linked an issue Jan 20, 2022 that may be closed by this pull request
Docker server images builds are broken #3955
Closed
@jzwang43
Copy link
Contributor

Great! I think we might need to update the other dockerfiles too.

Updated! Thanks!

@jzwang43
Copy link
Contributor

Great! I think we might need to update the other dockerfiles too.

Actually we only need the update for 16.04. 20.04 doesn't require any changes.

@epicfaace
Copy link
Member Author

lgtm

@epicfaace epicfaace merged commit ed1b16e into master Jan 20, 2022
@epicfaace epicfaace deleted the epicfaace-patch-8 branch January 20, 2022 16:28
@teetone teetone mentioned this pull request Jan 24, 2022
Merged
@epicfaace epicfaace mentioned this pull request Mar 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker server images builds are broken
2 participants
@epicfaace @jzwang43