Improve handling if user does not have access to the server #3982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's show an error message like in https://worksheets.codalab.org/worksheets/0xbd86869844074a02aced04b5959153 for consistency:
|
|
@jzwang43 Are some unit tests still failing? |
Seems to be a test issue not with the dockerfiles that I fixed. |
|
Is this related to the test cases you and Ashwin wrote? What is the next step? @jzwang43 |
@epicfaace I have updated the code to use the error message you mentioned. Can I get a review on this? Thanks. |
epicfaace
requested changes
Feb 7, 2022
codalab/rest/schemas.py
Outdated
| @@ -307,6 +306,7 @@ class UserSchema(Schema): | |||
| url = fields.Url(allow_none=True) | |||
| date_joined = fields.LocalDateTime("%c") | |||
| avatar_id = fields.String(allow_none=True) | |||
| has_access = fields.String(allow_none=False) | |||
There was a problem hiding this comment.
This should be a Boolean I think
epicfaace
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Related issues
Fixes #3961
Screenshots
Shows alert if user doesn't have access to the server:
Checklist