Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling if user does not have access to the server v2 #3993

Merged
merged 7 commits into from
Feb 16, 2022

Conversation

jzwang43
Copy link
Contributor

@jzwang43 jzwang43 commented Feb 9, 2022

Reasons for making this change

User creates an account on cs324.codalab.org
User gets ugly experience (can't create worksheets, etc.)

Related issues

Fixes #3961

Screenshots

Shows alert if user doesn't have access to the server:
image

Checklist

  • I've added a screenshot of the changes, if this is a frontend change
  • I've added and/or updated tests, if this is a backend change
  • I've run the pre-commit.sh script
  • I've updated docs, if needed

@jzwang43 jzwang43 marked this pull request as draft February 9, 2022 20:37
@jzwang43 jzwang43 marked this pull request as ready for review February 15, 2022 01:19
@pranavjain
Copy link
Contributor

@jzwang43 You might want to update the branch

@mergify mergify bot merged commit 2a5086c into master Feb 16, 2022
@mergify mergify bot deleted the fix/3961 branch February 16, 2022 05:40
@epicfaace epicfaace mentioned this pull request Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cs324 - users who haven't been added to the protected mode server get ugly exceptions
3 participants