Fix/3911-cl-store infer storage type from url #4061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epicfaace
reviewed
Apr 5, 2022
Co-authored-by: Ashwin Ramaswami <[email protected]>
|
@wwwjn thanks, can you fix format? |
…eets into fix/3911-cl-store
Yes! It seems that after run pre-commit.sh, I mistakenly change a file. Fixed now! |
epicfaace
reviewed
Apr 5, 2022
percyliang
reviewed
Apr 6, 2022
percyliang
reviewed
Apr 6, 2022
percyliang
reviewed
Apr 6, 2022
percyliang
reviewed
Apr 6, 2022
percyliang
reviewed
Apr 6, 2022
epicfaace
requested changes
Apr 7, 2022
epicfaace
reviewed
Apr 8, 2022
epicfaace
approved these changes
Apr 8, 2022
| if args.url is not None: | ||
| inferred_type = parse_linked_bundle_url(args.url).storage_type | ||
| if args.storage_type is None: | ||
| bundle_store_info["storage_type"] = inferred_type |
There was a problem hiding this comment.
Is bundle_store_info["storage_type"] set when args.storage_type is specified?
There was a problem hiding this comment.
I think No? When storage_type is specified, it should have higher priority than inferred_type. And if a user use a wrong command like "--storage_type azure_blob --url gs://bucket", we will raise Error. If the args.storage_type is specified and equals inferred_type, it's ok not to set it.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fix issue #3911
Design choices
Infer storage type from url in bundle_cli.py rather than bundles.py line 514, because the field
storage_typedatabase modelBundleStoreSchemacan not be NULL, so we need to infer the storage type before insert into database. And we need to know the storage type as soon as possible so I put it in cl command.Changes
Related issues
#3911
Screenshots
N/A
Checklist