Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing empty --worker-tag to worker managers #4121

Merged
merged 8 commits into from
Aug 24, 2022
Merged

Allow passing empty --worker-tag to worker managers #4121

merged 8 commits into from
Aug 24, 2022

Conversation

epicfaace
Copy link
Member

@epicfaace epicfaace commented May 31, 2022

  • Allow passing empty --worker-tags to worker managers (previously this didn't work). This allows us to run k8s worker managers that are not tied to a particular tag.

Part of #4090, for issue #3975

…-worker-tag-exclusive is only applied when --worker-tag is set
@epicfaace epicfaace requested review from teetone and wwwjn May 31, 2022 19:09
@epicfaace epicfaace marked this pull request as ready for review May 31, 2022 19:09
codalab_service.py Outdated Show resolved Hide resolved
codalab/worker/main.py Outdated Show resolved Hide resolved
@epicfaace epicfaace changed the title k8s worker manager --worker-tag improvements Allow passing empty --worker-tag to worker managers Jun 3, 2022
@mergify mergify bot merged commit 1b27806 into master Aug 24, 2022
@mergify mergify bot deleted the tte branch August 24, 2022 20:41
@leilenah leilenah mentioned this pull request Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants