Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preparing and finalizing text to upload progress. #4248

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

leilenah
Copy link
Collaborator

@leilenah leilenah commented Sep 8, 2022

Reasons for making this change

It can be confusing to a user if upload UI hangs at 0% or 100%. This is not really an issue with small files, but can happen if the user is trying to upload a large file.

This change adds a preparing and finalizing indicator to the upload progress UI.

Related issues

#4137
#4177

Screenshots

Before (prod)

20220907203742231.mp4

After (local)

20220907203847280.mp4

Checklist

  • I've added a screenshot of the changes, if this is a frontend change
  • I've added and/or updated tests, if this is a backend change
  • I've run the pre-commit.sh script
  • I've updated docs, if needed

Copy link
Collaborator

@percyliang percyliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch. Later, we might want to provide users with more insight into what's going on in the preparing and finalizing stages..

@mergify mergify bot merged commit 25f9ab8 into master Sep 8, 2022
@mergify mergify bot deleted the fix/4137-uploading-state branch September 8, 2022 20:43
@epicfaace epicfaace mentioned this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants