Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bundle view responsiveness. #4260

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Conversation

leilenah
Copy link
Collaborator

Reasons for making this change

Unwanted horizontal scrolling can be observed when bundle content (like command, stdout, stderr, etc) has long lines (see sample screen recording below). This change prevents that unwanted scrolling.

I have also added css that collapses the bundle view at the 600px breakpoint, ordering the bundle sidebar above the bundle content. This prevents the bundle view from becoming squished.

Related issues

#4216

Screenshots

Before [prod]

20220926200732803.mp4

After [local]

20220926200818947.mp4

Checklist

  • I've added a screenshot of the changes, if this is a frontend change
  • I've added and/or updated tests, if this is a backend change
  • I've run the pre-commit.sh script
  • I've updated docs, if needed

@leilenah leilenah linked an issue Sep 27, 2022 that may be closed by this pull request
4 tasks
Copy link
Collaborator

@percyliang percyliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can imagine there are times when you don't want wrapping, because it might be confusing where lines start (e.g., for code). I'm not sure - what do you think?

Can we look at the real worksheets from the gallery on prod (https://worksheets.codalab.org/worksheets/0x818930127c4d47de84c1ceaadf04d014/) and see how it feels?

@leilenah
Copy link
Collaborator Author

@percyliang we basically have to choose between wrapping and the horizontal scroll. I was thinking that people who encounter wrapping can still expand their screen (to an extent of course) in order to un-wrap things. They're also able to open the output in a new window for more space.

As a user I think I would prefer wrapping to horizontal scroll, but I don't feel strongly. Lmk your preference 👍

@percyliang
Copy link
Collaborator

I see the benefits of both. Do you have any thoughts from the real worksheets?

@leilenah
Copy link
Collaborator Author

@percyliang based on the worksheets on prod, I am leaning towards wrapping over having a horizontal scrollbar. I'm being tipped into that direction due to the fact that for the expanded bundle view, the horizontal scroll bar appears way at the bottom of the content. So the user may not instantly realize why some of their output is getting cut off. E.g.

image

With wrapping, it may seem more intuitive to expand your screen or open up the output in a new window.

@percyliang
Copy link
Collaborator

Wrapping it is then!

@leilenah leilenah merged commit e1cfb03 into master Sep 28, 2022
@leilenah leilenah deleted the 4216/bundle-view-responsiveness branch September 28, 2022 20:48
@epicfaace epicfaace mentioned this pull request Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve bundle view responsiveness
2 participants