Fix Flaky CI - Mimic #4454
Merged
Fix Flaky CI - Mimic #4454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewJGaut
commented
Apr 27, 2023
requirements.txt
Outdated
| @@ -32,6 +32,7 @@ selenium==3.141.0 | |||
| requests==2.25.0 | |||
| azure-storage-blob==12.4.0 | |||
| azure-core==1.8.0 | |||
| msrest==0.6.21 | |||
There was a problem hiding this comment.
Note: this is a development issue I just discovered b/c I'm working on a new laptop. We need to pin msrest to 0.6.21 to get it to work with our version of azure-core. (see here). We might want to add this to a different PR, though.
There was a problem hiding this comment.
Moved to new PR.
|
I've rerun the test several times and it seems to pass every time, so I believe the issue is fixed. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses one part of issue #4433 by addressing the flakiness of the Mimic test.
What happened was, after we removed the data hash, we had to write code in the test_cli.py file to produce something equivalent for tests that relied on having a check that the contents of two bundles were the same. To do this, we download the bundle and then hash the files in the directories in a function in the test_cli.py file.
However, that function did not
waiton the uuid of the bundle being data hashed, and so sometimes the downloaded contents wouldn't match the contents of the bundle being mimicked, thereby causing occasional failures.(Note: This is still a hypothesis. I could not reproduce the issue locally but could on CI, but I have re-run the mimic CI test many times after this change and it has yet to fail.)