4360 cl search bug fix #4545
Open
4360 cl search bug fix #4545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriWebb
force-pushed
the
4360-cl-search-bug-fix
branch
from
7faf458
to
b8dd15d
Compare
AriWebb
force-pushed
the
4360-cl-search-bug-fix
branch
from
dd60626
to
7faf458
Compare
|
Is this ready for review? |
|
yes this is ready for review @epicfaace |
percyliang
reviewed
Nov 16, 2023
| @@ -1939,6 +1939,12 @@ def test_search_time(ctx): | |||
| time.sleep(1) | |||
| time3 = datetime.now().isoformat() | |||
|
|
|||
| # Check date format works correctly, GH issue #4360 | |||
| check_not_equals( | |||
There was a problem hiding this comment.
This is oddly specific - can we test for what the output should be?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
We want cl search to have uniform functionality. Namely, we want the date parser for the ".after" and ."joined_after" arguments to behave similarly.
Related issues
Resolving Issue 4630 issue.
Checklist