Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates the store field in codalab worksheet UI to display real bundle location. #4593

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Updates the store field in codalab worksheet UI to display real bundle location. #4593

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
71e03fd
fix
HidyHan Apr 23, 2024
77001f9
fix
HidyHan Apr 23, 2024
d77b5f7
remove import
HidyHan Apr 23, 2024
f5486f0
lint
HidyHan Apr 30, 2024
138c4a3
Merge branch 'master' into blob
HidyHan May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion frontend/src/components/worksheets/BundleDetail/BundleDetail.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { useEffect, useState } from 'react';
import { JsonApiDataStore } from 'jsonapi-datastore';
import { findDOMNode } from 'react-dom';
import useSWR from 'swr';
import { apiWrapper, fetchFileSummary } from '../../../util/apiWrapper';
import { apiWrapper, fetchBundleStores, fetchFileSummary } from '../../../util/apiWrapper';

import ConfigPanel from '../ConfigPanel';
import ErrorMessage from '../ErrorMessage';
Expand Down Expand Up @@ -111,6 +111,13 @@ const BundleDetail = ({
bundleInfo.metadataTypes = response.data.meta.metadata_type;
setBundleInfo(bundleInfo);
setMetadataErrors([]);

fetchBundleStores(uuid)
.then((response) => {
const bundleStore = response.data[0].attributes.name;
bundleInfo.bundleStore = bundleStore;
setBundleInfo(bundleInfo);
});
},
});

Expand Down
4 changes: 2 additions & 2 deletions frontend/src/components/worksheets/BundleDetail/BundleDetailSideBar.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,8 @@ class BundleDetailSideBar extends React.Component {
{(showRunFields || showDatasetFields) && (
<BundleFieldRow
label='Store'
field={bundle.store}
onChange={(store) => onUpdate({ store })}
field={bundle.bundleStore}
onChange={(bundleStore) => onUpdate({ bundleStore })}
/>
)}
</BundleFieldTable>
Expand Down
Loading