Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.3.3 compatiblity error #13

Closed
greendee opened this issue Apr 24, 2014 · 5 comments
Closed

python 3.3.3 compatiblity error #13

greendee opened this issue Apr 24, 2014 · 5 comments
Assignees

Comments

@greendee
Copy link

I try get new messages, but component crashes in django_mailbox\models.py in line 133 - 'module' object has no attribute 'unquote'. I have no idea how to figure it out.

@coddingtonbear coddingtonbear self-assigned this Apr 24, 2014
coddingtonbear pushed a commit that referenced this issue Apr 24, 2014
* Refactoring unicode payload handling of mis-encoded payloads.
* Uses six.moves.urllib to find proper urllib versions.
@coddingtonbear
Copy link
Owner

Thanks for reporting this @greendee! Clearly the tests I put in place to validate Python 3 support weren't quite good enough, but I think this should patch things up for you.

I've just released a new version of this library with fixes (002e33b) as version 3.1.2. Could I convince you into giving it a shot to make sure I haven't missed anything? Feel free to re-open this ticket if things blow up ❤️.

Cheers!

@greendee
Copy link
Author

django_mailbox\transports\imap.py line 34: 'module' object has no attribute 'Errors'. sorry, but this is happens again.
and: django_mailbox/transports/imap.py line 32: nethod only allowed string or int, byte given.
i think need to use email.message_from_bytes(msg_contents[0][1]).
can't reopen this issue, becose it closed not by me.
thank you for your work anyway.

@coddingtonbear
Copy link
Owner

Hrmph....well, OK, I guess this gives me an excuse to spin up a Django+Python 3 instance; I'll have a look at this tonight.

Also, thanks for working with me on this, @greendee, you're (apparently) the only person who has tried to use this on Python 3 😄.

@coddingtonbear
Copy link
Owner

Woot, ok! Fixed & tested on Python3; added a couple tests to catch this kind of problem in the future, and released as v. 3.2.

Cheers!

@greendee
Copy link
Author

I test it to. It works! Congrats! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants