Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

event PriceUpdated is never emitted #23

Closed
code423n4 opened this issue May 4, 2021 · 2 comments
Closed

event PriceUpdated is never emitted #23

code423n4 opened this issue May 4, 2021 · 2 comments
Labels
0 (Non-critical) bug Something isn't working sponsor confirmed

Comments

@code423n4
Copy link
Contributor

Handle

paulius.eth

Vulnerability details

Impact

event is never emitted:
/// @notice The event emitted when the stored price is updated
event PriceUpdated(string symbol, uint price);

Recommended Mitigation Steps

Emit this event where it was intended.
@code423n4 code423n4 added 0 (Non-critical) bug Something isn't working labels May 4, 2021
code423n4 added a commit that referenced this issue May 4, 2021
@code423n4
paulius.eth issue #23
c226a94
@ghoul-sol
Copy link
Collaborator

Event is not needed and will be deleted.

@ghoul-sol ghoul-sol mentioned this issue May 5, 2021
Open
@cemozerr
Copy link
Collaborator

Duplicate of #38

@cemozerr cemozerr marked this as a duplicate of #38 May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) bug Something isn't working sponsor confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cemozerr @ghoul-sol @code423n4