Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total supply dependency on decimals #56

Open
code423n4 opened this issue Sep 8, 2021 · 0 comments
Open

Total supply dependency on decimals #56

code423n4 opened this issue Sep 8, 2021 · 0 comments
Labels

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

Total supply depends on the decimals. I think it makes sense to express totalSupply something like this to make it more readable and maintainable in case you will decide to change decimals:

/// @notice EIP-20 token decimals for this token
uint8 public constant decimals = 8;

/// @notice Total number of tokens in circulation (100 million NOTE)
uint256 public constant totalSupply = 10_000_0000 * 10 ** decimals;
@code423n4 code423n4 added 0 (Non-critical) bug Something isn't working labels Sep 8, 2021
code423n4 added a commit that referenced this issue Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants