Basket.sol#initialize() Remove redundant assertion can save gas

[code423n4]

Handle

WatchPug

Vulnerability details

https://github.com/code-423n4/2021-10-defiprotocol/blob/7ca848f2779e2e64ed0b4756c02f0137ecd73e50/contracts/contracts/Basket.sol#L41-L57

function initialize(IFactory.Proposal memory proposal, IAuction auction_) external override {
    require(address(factory) == address(0));
    require(!initialized);

    publisher = proposal.proposer;
    licenseFee = proposal.licenseFee;
    factory = IFactory(msg.sender);
    auction = auction_;
    ibRatio = BASE;
    tokens = proposal.tokens;
    weights = proposal.weights;
    approveUnderlying(address(auction));

    __ERC20_init(proposal.tokenName, proposal.tokenSymbol);

    initialized = true;
}

factory will never be address(0) if initialized == true as it's been set to msg.sender when initialize() being called.

Removing require(address(factory) == address(0)); can make the code simpler and save some gas.

Recommendation

Remove the redundant assertion.

[GalloDaSballo]

Duplicate of #29