Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change unnecessary storage variables to constants can save gas #85

Open
code423n4 opened this issue Nov 22, 2021 · 0 comments
Open

Change unnecessary storage variables to constants can save gas #85

code423n4 opened this issue Nov 22, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

WatchPug

Vulnerability details

https://github.com/code-423n4/2021-11-overlay/blob/1833b792caf3eb8756b1ba5f50f9c2ce085e54d0/contracts/OverlayV1UniswapV3Market.sol#L14-L14

uint256 internal X96 = 0x1000000000000000000000000;

Some storage variables include X96 will not never be changed and they should not be.

Changing them to constant can save gas.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 22, 2021
code423n4 added a commit that referenced this issue Nov 22, 2021
@code423n4
WatchPug issue #85
d6211d1
@mikeyrf mikeyrf mentioned this issue Dec 7, 2021
Closed
@mikeyrf mikeyrf added sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons and removed sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons labels Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikeyrf @code423n4