calldata vs memory in solidity gas usage

[code423n4]

Handle

pants

Vulnerability details

use calldata instead of memory when possible to save GAS

For example in LinearVesting.sol the following function (constructor) could be changed to:

constructor(
    IERC20 _vader,
    address[] memory vesters,
    uint192[] memory amounts
) {
    require(
        _vader != IERC20(_ZERO_ADDRESS) && vesters.length == amounts.length,
        "LinearVesting::constructor: Misconfiguration"
    );

    vader = _vader;

    uint256 total;
    for (uint256 i = 0; i < vesters.length; i++) {
        require(
            amounts[i] != 0,
            "LinearVesting::constructor: Incorrect Amount Specified"
        );
        vest[vesters[i]].amount = amounts[i];
        total = total + amounts[i];
    }
    require(
        total == _TEAM_ALLOCATION,
        "LinearVesting::constructor: Invalid Vest Amounts Specified"
    );

    transferOwnership(address(_vader));
}

could be changed to:

constructor(
    IERC20 _vader,
    address[] calldata vesters,
    uint192[] calldata amounts
) {
    require(
        _vader != IERC20(_ZERO_ADDRESS) && vesters.length == amounts.length,
        "LinearVesting::constructor: Misconfiguration"
    );

    vader = _vader;

    uint256 total;
    for (uint256 i = 0; i < vesters.length; i++) {
        require(
            amounts[i] != 0,
            "LinearVesting::constructor: Incorrect Amount Specified"
        );
        vest[vesters[i]].amount = amounts[i];
        total = total + amounts[i];
    }
    require(
        total == _TEAM_ALLOCATION,
        "LinearVesting::constructor: Invalid Vest Amounts Specified"
    );

    transferOwnership(address(_vader));
}