internal function _addLiquidity in the router is unnecessary

[code423n4]

Handle

jonah1005

Vulnerability details

Impact

The internal function _addLiquidity seems to be unnecessary.
The internal function only create a Pool and returns (amountA, amountB) = (amountADesired, amountBDesired);

It's misleading and unnecessary.

Proof of Concept

VaderRouter.sol#L123-L150

Tools Used

None

Recommended Mitigation Steps

Recommend to make it simple and transparent.

    function addLiquidity(
        IERC20 tokenA,
        IERC20 tokenB,
        uint256 amountADesired,
        uint256 amountBDesired,
        address to,
        uint256 deadline
    )
        public
        override
        ensure(deadline)
        returns (
            uint256 amountA,
            uint256 amountB,
            uint256 liquidity
        )
    {
        IVaderPool pool;
        pool = factory.getPool(tokenA, tokenB);
        if (pool == IVaderPool(_ZERO_ADDRESS)) {
            pool = factory.createPool(tokenA, tokenB);
        }

        tokenA.safeTransferFrom(msg.sender, address(pool), amountADesired);
        tokenB.safeTransferFrom(msg.sender, address(pool), amountBDesired);
        liquidity = pool.mint(to);
    }