QA Report

[code423n4]

• Error message is not delivered and thrown

  • Diamond.sol - _initializeDiamondCut: the error returned by delegatecall may be diverse.

• Lack of validity checking when setting important storage states

  • DiamondInit.sol - initialize: require _governor, _validator, _genesisBlockHash to be none-zero, and _verifier, _allowList to be existing contracts.
  • Governance.sol - setVerifier: require _newVerifier to be an existing contract.
  • L1ERC20Bridge.sol - constructor: require _mailbox, _allowList to be existing contracts.
  • L1EthBridge.sol - constructor: require _mailbox, _allowList to be existing contracts.

• The comment does not match the function

  • Miss parameters in comments for DiamondInit.sol - initialize

[c4-judge]

GalloDaSballo marked the issue as grade-c

[GalloDaSballo]

Needs more

[GalloDaSballo]

1L 2R

[GalloDaSballo]

Still recommend adding more findings